Liam Miller-Cushon

Making it an error might be too aggressive, but this could be a useful warning. I agree that we'd probably want to ignore literals, and maybe also floating point.

I tried merging this an am seeing failures like the ones in https://github.com/google/error-prone/actions/runs/12602521683/job/35125772504?pr=4744 I'm able to reproduce those locally with: ``` mvn clean install -DskipTests=true mvn test -e ... Caused...

I'm fine with changing the invoke in CI invocation, but if separate `mvn install` and `mvn test` don't work that seems like it might also affect non-CI development builds? Or...

Hi, thanks for raising this and for the suggested fix. I think the code generated by here by immutables sounds similar to [AutoValue](https://github.com/google/auto/tree/main/value). The check has a heuristic for AutoValue:...

Thanks, I agree this is an area that could be improved. The current behaviour is supposed to be a safe default so we don't actually remove worthwhile comments, but I...

I wanted to chime in to say I haven't spent a lot of time considering the details, but I am supportive of Error Prone providing better support for structured diagnostics....

> I'd appreciate a first architectural review of the changes, including how well/bad that would play with other Google-internal code. I'm happy to take a look, can you clarify which...

Thanks for the nudge :) > I spent some time today trying to do such a thing; I'm having a hard time finding how to pass my `SarifWriter` to the...

I was reminded of this by discussion in #5031 and #444 To try to recap, I think the two options we've discussed here are: 1. Add a flag to Error...

This might be resolved by updating the GraalVM version for releases, I think we could switch to 25 now: https://github.com/google/google-java-format/blob/60a00f20dd6a2f754774617aa803d06ad26a5ac4/.github/workflows/release.yml#L105