Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

There's some related discussion in the docs for [MutableMethodReturnType](http://errorprone.info/bugpattern/MutableMethodReturnType). It's OK to prefer `List.of`, but having a static `Immutable*` type does have advantages: it makes it clear to users of...

One variation on this (which is similar to a workflow we use at Google) is to emit the diagnostics, and then have a separate tool that can add `@SuppressWarning`s for...

The annotation is only valid on declarations of variables, methods, and classes. The separate tool we use parses the file and then looks at the syntax tree to find the...

> > I took a quick pass. I think this makes sense overall, I will try to do some internal testing. > > Sounds good! Let me know how things...

> This issue has not had any activity for 60 days and will be automatically closed in two weeks The issue in #13177 is still happening

For posterity there was some discussion about the issue and possible solutions in https://github.com/bazelbuild/bazel/pull/21521 I would be nice if JaCoCo could recognize this case and handle it instead of emitting...

I'm leaning towards (b). (a) would be OK, the main drawback is just needing to create another configuration mechanism and plumb it through to JavaBuilder. > If we're going to...

> But I'm guessing that #5 is the main problem here. Without being able to know which kind of annotation it is, our moving it could just make it even...

This issue describes behaviour of the OpenJDK build that Bazel is using, I'm not sure there's a good fix in Bazel itself. If you don't want to use the embedded...