Liam Miller-Cushon

cc @graememorgan The context is that we are investigating using guice to instantiate bugcheckers, instead of relying on what's effectively a home-grown DI implementation: https://github.com/google/error-prone/pull/3701

@lazaroclapp I'd like to avoid having this be an abrupt breaking change, so if there are ways to make this less invasive / easier to absorb, I'm open to suggestions....

> > However, if one adds `@Inject` right now, then [UnnecessarilyVisible](https://errorprone.info/bugpattern/UnnecessarilyVisible) complains about the constructor being public, while [`ScannerSupplierImpl#instantiateChecker(BugCheckerInfo)`](https://github.com/google/error-prone/blob/b7e2cd7b37fe9a29b0508ad84998e366f3fdb921/check_api/src/main/java/com/google/errorprone/scanner/ScannerSupplierImpl.java#L63-L95) only considers public constructors: a catch-22. > > Then I assume...

https://github.com/google/google-java-format/issues/883

Some previous discussion in https://github.com/google/error-prone/issues/2196

I don't have any open source code I can point to, but we've run into this a handful of times. I think there's value in staying as close as possible...

I dug up a couple of examples. ```java case WIRETYPE_FIXED64: while (true) { target.add(input.readDouble()); if (input.isAtEnd()) { return; } int nextTag = input.readTag(); if (nextTag != tag) { this.nextTag =...

Thanks for the report, I think this is a known issue related to this TODO: https://github.com/google/error-prone/blob/1966d6d30224d0e33d90271aa2f5e8d9bea4453f/core/src/main/java/com/google/errorprone/bugpatterns/PatternMatchingInstanceof.java#L112

It should show multiple errors within the same file, but the default behaviour is to stop after the first file with errors. If you want to get the full list...

These are still preview features, so we may want to wait until the feature is finalized. We've added support for preview features before, and may do that again depending on...