Michael Goulet

Results 176 comments of Michael Goulet

howdy @JulianKnodt, what's the status of this?

@jackh726, is this up for grabs? i would be interested in continuing the work in the linked PR. been looking for some chalk work.

Also not sure if this is better as a t-lang proposal. On one hand, the `Fn*` traits are pretty well known, on the other, there are not one but two...

Yes @llogiq, for example all spans from `Span::shrink_to_lo()` are zero width

Also worth noting is that the `Span` struct doesn't actually store its innards as `lo: BytePos, hi: BytePos`. It stores it in a packed representation (I think?) and only `SpanData`...

Since this change will be mostly moving things around and name changing, I don't think this is particularly controversial. Things under `rustc_typeck/src/check/fn_ctxt` are already somewhat self-contained. @rustbot second

@hanusek's #961 reminded me that this PR was open. @dtolnay: is this change something you consider reasonable, and if so, can I get a review on it sometime? If it's...