Michael Goulet

Results 300 comments of Michael Goulet

Note: Is it possible to provide a UI test (like https://github.com/dtolnay/trybuild) for tracing macros? Otherwise, any recommendations on how to provide a test for this change, since all affected code...

> it's fine to introduce a dev dependency on trybuild for testing this. @davidbarsky just told me to do the same -- will do!

Okay, think this is ready for review. Sorry for the force-pushes, wanted to make sure the history was clean.

Good to know. Guess I really should've read the contributing guide first, my bad.

(sorry, that force push is because I am dumb and don't know how to use git)

also used to force-pushing when working on rustc because bors doesn't auto-squash :smile_cat:

@jpalaciosdev: That regressed in #96727 cc @oli-obk Seems to be a problem with RPIT inference in borrowck

@bors retry the test failure doesn't look related

I think this is fine to land now, since the polymorphism thing is already labeled with a `// HACK` comment. r=me once rebased

> Should the fix instead transform this to Box::::into_raw(b)? I think so, yes.