Michael Goulet comments

Results 300 comments of


                                            Michael Goulet

Unions require Copy fields, but ignore regions in the check

@Mark-Simulacrum: In https://github.com/rust-lang/rust/issues/55149#issuecomment-1150197680, @joshtriplett said: > We'd like to close the remainder of this, and just not allow non-Copy union fields in general, changing that from a feature gate to...

`dyn XXX` had impl `Debug`, but `dyn XXX + Send` can't Debug.

You need to implement `Debug` for `dyn ConnectionDriver + Send`, which in this usage acts as a distinct type from `dyn ConnectionDriver`.

`dyn XXX` had impl `Debug`, but `dyn XXX + Send` can't Debug.

I can probably implement a better error message for this, though...

`dyn XXX` had impl `Debug`, but `dyn XXX + Send` can't Debug.

@rise0chen, I think that would be a backwards-incompatible change with current behavior, because then these `impl`s would overlap: ```rust trait Bar {} trait Foo {} impl Foo for dyn Bar...

ICE when trying to use `typeof(reference_expr)` in a struct

We should probably replace the lifetimes in the `typeof` recovery with `'static`

Update Mac Catalyst support for Clang 13

good idea, because highfive bot chose me, but I am also not an expert :^)

Delay formatting trimmed path until lint/error is emitted

@bors r=davidtwco

const_prop_lint: Consider array length constant even if array is not

r? oli-obk cc @JakobDegen

Suggest `use` if `import`, `using`, or `require` is used instead

For the record, on nightly, both `import` and `using` suggest using `use`. I'm sure it's not that difficult to add `require`.

hir::Generics: convert `has_where_clause_predicates` field into method

I'm curious if changing the size of hir generics has any noticeable effect on perf, since most people would be messing with it behind a `&hir::Generics