Michael Goulet comments

Results 196 comments of


                                            Michael Goulet

Add team membership characteristics section

Action item: We decided during the meeting August 30, 2023 that @yaahc will open an FCP on this when she's cleared Josh's final comments. note to Jane: `@ rfcbot fcp...

Add team membership characteristics section

@rfcbot concern four boxes

Plan: Rust 2024 prelude

> are Future and IntoFuture traits that really need to be in the standard library? They certainly need to be in the standard library to support `async` and `await` desugaring....

cleanup `candidate_should_be_dropped_in_favor_of`

@craterbot check

Dealing with comments, and more specifically, around keywords

Yeah, also speaking as an individual: I think rustfmt deleting any comments is a bug. If there are positions that we want to especially discourage comments, rustfmt can move them...

ICE: `explicit index of non-indexable type`

That just exposed an underlying bug.

`unsafe_code` lint does not properly detect usages of `unsafe` functions when in an unsafe scope

Adding some context -- it seems like the `forbid(unsafe_code)` lint only denies `unsafe {}` block usages, not unsafe operations. Therefore, when we're inside of a context with that implicitly allows...

Uplift `AliasTy` and `AliasTerm`

@bors r=lcnr

Uplift `AliasTy` and `AliasTerm`

@rust-timer build 3dd3328e4b318aa8f7df6dd6f687b53f7ad51b22

ICE: `explicit deref of non-derefable type`

This likely exposed a preexisting bug in `ref_pat_everywhere` cc @Jules-Bertholet previously `ExprUseVisitor` was silently bailing when it couldn't deref a type it expected to be able to deref.