Michael Goulet

Results 300 comments of Michael Goulet

> Where the generic arguments can't be inferred in the GenericAssocMethod::::default_hello form. Applying this or leaving it results in invalid code which causes cargo to print a bug message. Then...

Marking this as `S-waiting-on-author` so it can be adjusted to make it not `MachineApplicable` if it doesn't actually fit the criteria for `MachineApplicable`, namely that it should produce code that...

Probably a different root cause, even if they have the same message.

r? types (am sick right now, can't review much)

For context, here's the experimentation I have done: * without any additional inferences changes (1687 regressed): https://github.com/rust-lang/rust/pull/98456#issuecomment-1166366084 * With some inference hacks (13 regressed): https://github.com/rust-lang/rust/pull/98456#issuecomment-1166399219 But even with those inference...

r? compiler not sure if I'm the best person to review this

I think @oli-obk fixed this (inadvertently?) in #102700

Yes a minimized test PR would be appreciated.

@estebank we don't do it in this case because these are references to fndef and not just fndef types themselves. We can probably add logic to deeply compare if types...