Michael Goulet comments

Results 300 comments of


                                            Michael Goulet

Add PhantomData marker to Context to make Context !Send and !Sync

I believe this is T-libs-api since it affects an (auto) impl of a public type in std r? rust-lang/libs-api @rustbot label +T-libs-api

Migrate rustc_resolve to use SessionDiagnostic

@rajputrajat, can you please remove all of these merge commits? We have a no merge commit policy.

Migrate rustc_resolve to use SessionDiagnostic

@rajputrajat -- I think you need to do something like `git pull --rebase $REMOTE master` where `$REMOTE` is the git remote corresponding to upstream, i.e. the rust-lang/rust repo (not your...

translation: doc comments with derives, subdiagnostic-less enum variants, more derive use

Looks good. @bors r+

Add TyAlias into rustc_type_ir TyKind enum

> Add TyAlias into rustc_hir TyKind enum This title is a bit out of date. Maybe "Add TyAlias as a distinct type in typeck" or something that makes this not...

Implement `std::marker::Tuple`, use it in `extern "rust-call"` and `Fn`-family traits

@bors try

Implement `std::marker::Tuple`, use it in `extern "rust-call"` and `Fn`-family traits

@craterbot check

Add fake return to improve span on type error in `tracing::instrument`

I think opening a PR for this would be fine. Alternatively, one could do the same thing as `#[async_trait]` and use an alternative desugaring to provide the same return type...

hir::Generics: convert `has_where_clause_predicates` field into method

Closing due to inactivity!

Stabilize `--json=unused-externs(-silent)`

Yeah, stabilization needs an FCP. In the interest of getting it kicked off sooner than later, let's do that now. @rfcbot fcp merge