Côme Chilliet
Côme Chilliet
> * [ ] config file is opened in read/write mode, even for unauthenticated page loads. > > * Changing this to read-only (except for the admin settings pages) would...
It is the call to `OC_Util::getInstanceId()` that will generate and write a new instance id if missing, and write a configuration file with only this if configuration was not loaded...
@Pytal Tests are failing: ``` There were 2 errors: 1) OCA\Settings\Tests\UserMigration\AccountMigratorTest::testImportExportAccount with data set #0 ('63404cb1-a5d8-40b3-bb18-ac3a987740aa', array(array('displayname', 'Steve Smith', 'v2-local', '0', ''), array('address', '123 Water St', 'v2-local', '0', ''), array('website',...
> @come-nc please fix the test fixed
:heart:
`PHP Fatal error: Cannot use OCP\Files\SimpleFS\ISimpleFile as ISimpleFile because the name is already in use in /home/runner/work/server/server/tests/Core/Controller/AvatarControllerTest.php on line 42`
@luzpaz Can you rebase please?
@CarlSchwan It needs a compile-amend I think, but I suppose the bot cannot do that on an external repo? Do you know the manual command required to fix it?
@luzpaz Can you run `npm ci && npm run build` and commit the result ? If not I can import your branch in a local branch and do it.
> I'd rather not run `npm` rofl I’ll take it from here then.