Côme Chilliet

Results 358 comments of Côme Chilliet

Here is what I have locally: ``` > php ~/dev/test-freetype.php array(8) { [0]=> int(1) [1]=> int(0) [2]=> int(8) [3]=> int(0) [4]=> int(8) [5]=> int(-11) [6]=> int(1) [7]=> int(-11) } >...

No I think it depends upon which gd and/or freetype version is used. We need to test on as many setups as possible to see common patterns.

> OCA\Theming\Jobs\MigrateBackgroundImages Each time you run cron or only once? Can you run `occ background-job:list -c 'OCA\Theming\Jobs\MigrateBackgroundImages'` see if it lists anything?

I would prefer to switch to phpseclib implementation of RC4 to avoid running our own. Also, I would always use the wrapped version of seal and remove the fallback. I...

ref https://github.com/nextcloud/server/issues/35025

files_external tests are failing on PHPUnit >= 9, because we do: ``` $this->assertContains('foopass, $json['authSchemes']); $this->assertContains('barauth', $json['authSchemes']); ``` While the values are actually present in the keys. Changing for: ``` $this->assertContains('foopass',...

@icewind1991 Would you be able to publish icewind1991/samba-krb-test-apache with PHP 8 so that CI using that can run?

``` There were 2 failures: -- 695 |   696 | 1) Test\AppFramework\Controller\OCSControllerTest::testJSON 697 | Failed asserting that two strings are equal. 698 | --- Expected 699 | +++ Actual 700...

- [x] https://github.com/psalm/psalm-github-actions/issues/31 Even recent releases of `psalm-github-actions` are using php7.4. No activity since February. Should we fork and use our own image? Or is it possible to remove those...