Côme Chilliet comments

Results 358 comments of


                                            Côme Chilliet

Fix caching routes by users with an active session

I’m still wondering whether we should just load all enabled apps (for any user) even for users for which the application is not enabled. The whole feature about enabling only...

feat(snowflake): extend Entity class to support snowflakes

We should rename IGenerator and IDecoder to ISnowflakeGenerator and ISnowflakeDecoder, otherwise after a use all code is ambiguous. A value object for decoded snowflakes would be good as well.

[Bug]: Password change by admin not working with encryption: `Can not decrypt the recovery key. Maybe you provided the wrong password. Try again.`

Issue is from https://github.com/nextcloud/server/pull/48332 Hooks that were not called when master key is enabled are now called in the new event listener.

fix(share): Return empty string if no label is set

I thought some DB will treat null and empty string the same anyway and so we cannot differentiate in DB, no?

perf(external-share): Port to Entity and use snowflake Ids

According to integation tests you broke federated shares @CarlSchwan

Add event to customize app password token generation

Can you explain the usecase for allowing apps to control token generation? Is it to generate something somehow more secure? Would it make sense to instead improve/extend the token generation...

Uninstall class and <uninstall> block ignored in Nextcloud app removal

As said by @joshtrichards and can be seen in the documentation at https://docs.nextcloud.com/server/latest/developer_manual/app_development/info.html , the `` bloc is under the `` bloc. Also your class should implement `\OCP\Migration\IRepairStep`. `appinfo/uninstall.php` is...