server icon indicating copy to clipboard operation
server copied to clipboard

Add profile config migration

Open Pytal opened this issue 3 years ago • 3 comments

Preserves visibility settings when migrating accounts

Pytal avatar Jul 08 '22 19:07 Pytal

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 08 '22 19:07 github-actions[bot]

@Pytal Tests are failing:

There were 2 errors:

1) OCA\Settings\Tests\UserMigration\AccountMigratorTest::testImportExportAccount with data set #0 ('63404cb1-a5d8-40b3-bb18-ac3a987740aa', array(array('displayname', 'Steve Smith', 'v2-local', '0', ''), array('address', '123 Water St', 'v2-local', '0', ''), array('website', 'https://example.org', 'v2-local', '0', ''), array('email', '[email protected]', 'v2-federated', '0', ''), array('avatar', '', 'v2-local', '0', ''), array('phone', '+12178515387', 'v2-private', '0', ''), array('twitter', 'steve', 'v2-federated', '0', ''), array('organisation', 'Mytery Machine', 'v2-private', '0', ''), array('role', 'Manager', 'v2-private', '0', ''), array('headline', 'I am Steve', 'v2-local', '0', ''), array('biography', 'Lorem ipsum dolor sit amet, c...or eu.', 'v2-local', '0', ''), array('profile_enabled', '1', 'v2-local', '0', ''), array(array('additional_mail', '[email protected]', 'v2-published', '0', ''), array('additional_mail', '[email protected]', 'v2-local', '0', ''))), '/home/runner/work/server/serv...ex.jpg')

OCA\Settings\UserMigration\AccountMigratorException: Failed to import profile config

/home/runner/work/server/server/apps/settings/lib/UserMigration/AccountMigrator.php:199
/home/runner/work/server/server/apps/settings/tests/UserMigration/AccountMigratorTest.php:135

2) OCA\Settings\Tests\UserMigration\AccountMigratorTest::testImportExportAccount with data set #1 ('0c7caba9-4d45-4f56-a5ae-7132ff24b2ed', array(array('displayname', 'Emma Jones', 'v2-federated', '0', ''), array('address', '920 Grass St', 'v2-local', '0', ''), array('website', '', 'v2-local', '0', ''), array('email', '', 'v2-federated', '0', ''), array('avatar', '', 'v2-federated', '0', ''), array('phone', '', 'v2-local', '0', ''), array('twitter', '', 'v2-local', '0', ''), array('organisation', '', 'v2-local', '0', ''), array('role', '', 'v2-local', '0', ''), array('headline', '', 'v2-local', '0', ''), array('biography', '', 'v2-local', '0', ''), array('profile_enabled', '1', 'v2-local', '0', ''), array()), '/home/runner/work/server/serv...nt.png')

OCA\Settings\UserMigration\AccountMigratorException: Failed to import profile config

/home/runner/work/server/server/apps/settings/lib/UserMigration/AccountMigrator.php:199
/home/runner/work/server/server/apps/settings/tests/UserMigration/AccountMigratorTest.php:135

come-nc avatar Jul 11 '22 10:07 come-nc

Drafting pending merge

  • https://github.com/nextcloud/server/pull/33236

Pytal avatar Jul 14 '22 19:07 Pytal

/rebase

Pytal avatar Sep 01 '22 15:09 Pytal

CI failure unrelated

Pytal avatar Sep 01 '22 18:09 Pytal