Côme Chilliet

Results 358 comments of Côme Chilliet

(did not approve because I do not understand it…)

> I don't know how to make psalm shut up. `composer run psalm:update-baseline` ends in errors. `composer run psalm:update-baseline` is for removing errors from baseline, not adding them. You need...

Where does the \Redis class comes from? Is it phpredis/phpredis? If so, method keys should return an array: https://github.com/phpredis/phpredis#keys-getkeys The error points to the method returning a bool, which is...

> #28695 was an older alternative, not sure which is best No idea :confused:

https://github.com/nextcloud/server/pull/32363 from @CarlSchwan

> Thanks for taking care +1 > > In theory we can drop the iputils (symfony http-foundation) again and only use the ip-lib package: https://github.com/mlocati/ip-lib#check-if-an-address-is-contained-in-a-range > > This could also...

@kesselb I can make a PR to use ip-lib instead of iputils but I’d like to do so in a separate PR once this one is merged.