server icon indicating copy to clipboard operation
server copied to clipboard

Deprecated ILogger from IJob

Open CarlSchwan opened this issue 3 years ago • 6 comments

Since the ILogger will be soon removed we need to ensure that nothing in the public API use it.

  • Add start to replace execute but without ILogger
  • execute still exists but only call start internally
  • Use more OCP interface for background job
  • Fix a lot of warning in tests related to background jobs

CarlSchwan avatar Jun 28 '22 10:06 CarlSchwan

:heart:

come-nc avatar Jun 28 '22 14:06 come-nc

Since the ILogger will be soon

It will? :tada:

ChristophWurst avatar Jun 29 '22 12:06 ChristophWurst

Since the ILogger will be soon

It will? tada

still one year to wait since we need to wait 3 years after it has been deprecated, but since execute(...., ILogger) was for some app the only reasons why ILogger was still used, this should make it easier to get rid of it as soon as the 3 years are over.

CarlSchwan avatar Jun 29 '22 12:06 CarlSchwan

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

github-actions[bot] avatar Jul 14 '22 13:07 github-actions[bot]

Possible performance regression detected

Show Output
2 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

github-actions[bot] avatar Jul 28 '22 12:07 github-actions[bot]

PHP Fatal error: Cannot use OCP\Files\SimpleFS\ISimpleFile as ISimpleFile because the name is already in use in /home/runner/work/server/server/tests/Core/Controller/AvatarControllerTest.php on line 42

come-nc avatar Jul 28 '22 15:07 come-nc

ci failure unrelated

CarlSchwan avatar Aug 23 '22 14:08 CarlSchwan