chrchr-github
chrchr-github
Feel free to reopen once comments have been addressed.
FWIW here's a reduced example: ~~~c++ class QModelIndex; struct ResultsTree { void copy(); QStandardItemModel mModel; QItemSelectionModel mSelectionModel{}; }; void ResultsTree::copy() { QString text; for (QModelIndex index : mSelectionModel.selectedRows()) { QStandardItem*...
> Yes, the comment is a copy-paste error. The failing regressions come from the fact that I fixed the function name of QDir::exists which used to be only "QDir". Do...
I think we now have only `QDir::exists()` instead of both `QFile::exists()` and `QDir::exists()`.
> My bad. I misread it. I'll provide a new qt.cfg + qt.cpp Please feel free to open your own PR.
What is the canonical use case for this?
> > What is the canonical use case for this? > > That is described in the ticket. [...] Thanks for the explanation. IDEs were mentioned in the ticket, but...
I think we should always pass `settings` if available, since that should only improve the results.
https://doc.qt.io/qt-6/qwidget.html#QWidget So there should be a noticeable difference in window behavior when passing a parent. Are those classes ever used as child windows?
Here's a reproducer: ~~~c++ struct S { enum class E : std::uint8_t { E0 }; void f(S::E e) { if (e == S::E::E0) {} } char a[20]; }; ~~~