chrchr-github
chrchr-github
Aren't those instances the canonical use case for `const_cast`, i.e. resolving between const/non-const overloads?
So we have inline suppressions, but don't check if they are (still) matched? Ugh.
> As most (all) of the issues are with having a suppression file and those do not apply to inline suppression at all maybe we should introduce `unmatchedInlineSuppression`? Sounds reasonable....
See https://github.com/danmar/cppcheck/pull/5428
After upgrading to head, I started getting lots of `unknownMacro` errors for `_T()`, because I was not passing an explicit platform. If `native` is actually supposed to work, then that...
> There's also some other ansi/unicode handling mapping in the code. This should actually be in the configuration (`_T` is already declared in `wxwidgets.cfg`). > Wrongly defined though (there is...
Now 2.14 has been released, and the issue is still present (an explicit platform must be passed to handle e.g. `_T()` macros).
So `validateVariables()` did not prevent the crash because we parse `m t(=a[]);` as a function declaration, and argument variables may not have a scope. What we need to verify is...
> What we need to verify is "Variables have a scope, or appear only in a function declaration". This is not so easy because of declarations like `auto f(T& x)...
As it turns out, we already have `SymbolDatabase::validateVariables()`, which checks for variables without scope. I wonder why this is not caught there? Edit: That's why: 🤦 ~~~ // TODO //validateVariables();...