chrchr-github

Results 118 comments of chrchr-github

> Hey @danmar. I haven't changed a Script at all and don't really know what the Scriptcheck is doing. Could you please help fixing this (hopefully) last issue? Have you...

Thanks for contributing. You should add some test cases to show for what code your new check warns or doesn't.

> Baffled by "format / build" check failure. Log message: `2022-02-13T12:13:15.7455536Z FAIL: lib/tokenize.cpp (File size changed from 491084 to 491087` All formatting (indents, braces etc) seems to be identical to...

If a function is not annotated and its definition is not seen, we cannot warn. But that's not really a FN, we are just missing information. On a side note,...

> We have `noexcept` for functions that never throw, and we have `[[noreturn]]` for functions that always throw, but there is no attribute for functions that can throw but not...

> > Unfortunately that [[noreturn]] tweak is only available for C++ users though. Not sure what we can ask our C users to do. > > Oh sorry! This is...

While it is true that there is no way to properly annotate a `FunctionThatDoesntAlwaysThrow()`,it doesn't really matter, since an always-non-returning function is required to suppress the warning in the original...

This could actually be useful to detect missing custom/user-generated header files, which might be required for proper analysis (cf. various daca@home errors). Of course, your list is very much incomplete...