chrchr-github

Results 118 comments of chrchr-github

fixed #12384 - removed misleading suggestion from `passedByValue` and `iterateByValue` messages

Just stating the fact is probably not enough to steer users in the right direction. And if 'pass by value + move' is used, the object will still be passed...

fixed #12384 - removed misleading suggestion from `passedByValue` and `iterateByValue` messages

> > So maybe we should just mention the alternatives ('const ref', 'pass by value + move', 'universal ref'?). > > stupid question; what do you mean with 'universal ref'?...

Tokenizer: run `simplifyTypedefCpp()` on C++ code only

Could be that `simplifyTypedefCpp()` is a misnomer and actually needs to run for C code as well... @danmar

cfg/qt.cfg - Change the Q_D definition to avoid false positives

Can you add a test in `qt.cpp`?

Fix #9657 FP on missing va_end() after non-returning function

I guess the point is that the function that calls `va_start` (`check_noret_va_end()`) doesn't return, since it calls a noreturn function.

Fix #13001 knownConditionTrueFalse with QVector::append()

Blocked by https://trac.cppcheck.net/ticket/13010

run selfchecks with `rules/token-matching.xml`

I guess it was intended to allow developers to check their code without having the `CHECK_INTERNAL` flag set. But the CI does that anyway. @orbitcowboy Do you actually use this...

run selfchecks with `rules/token-matching.xml`

So I would say we should get rid of it.

fix #11542: FP memleak when using memcpy() with pointer

`var->valueType()->pointer` should be 2 in this case.

Fixes for sanitizer errors from SPEC CPU testing

`long long` is still being used in some places.