chrchr-github

Results 118 comments of chrchr-github

What is the use case for this?

Please add a test in `test/cli/performance_test.py`.

Is there a reason not to implement caching in the regular `astTop()` function (i.e. why add `astFinalTop()`)?

I think this sounds reasonable: `astTop(bool iscache)`. And please add a comment explaining the parameter.

As noted in the ticket, this is caused by a bad simplification for any `struct UPPERCASENAME varname` declaration. If anything, we should fix that and not add another hack elsewhere....

I think we try to proceed even when there are unknown macros (by removing tokens that look like a macro name), which we shouldn't do in the first place.

Here's a related ticket: https://trac.cppcheck.net/ticket/11048 I would say we should just bail out with an error message on ambiguous code. But we also generally try to handle incomplete code, so...

In the case of #12207, we should track that `S` has already been defined, so `struct S s;` unambigously declares a variable. But this is probably difficult to implement. A...

Can we reduce the timeout in the #12847 test with this?

After modifying `.selfcheck_unused_suppressions`, we get `analyzeEnumValue(symboldatabase, settings): 0.001s (avg. 0.0005s - 2 result(s))'` on Windows but `Tokenizer::createTokens: 0.001111s (avg. 0.001111s - 1 result(s))` elsewhere. Not sure why.