chrchr-github

Results 93 comments of chrchr-github

> Sorry for going off-topic but we really need to take a strong look at this check. We currently do not apply these findings to our code and if we...

> > That could just be the ugly std::transform ones though > > Whats the problem with `std::transform`? ~~~ for (auto& i : v) i += 5; ~~~ vs. ~~~...

C++20 improves things a little: ~~~ bool f(const std::vector& v) { return std::ranges::any_of(v, [](const auto& s) { return s.empty(); }); } ~~~

But this PR is still about flagging iterators, which also make for unreadable code.

So I made this mergeable once more. How about it?

On the topic of parentheses, not sure if this is related: The token list currently does not contain the double parentheses in `foo((x = 1, x = x + 1));`...

This still requires approval.

Make noise until @danmar notices it? 😜

Let's mention @danmar again...