avoid some (unnecessary) default parameters in GUI class constructors / added TODOs

[firewave]

[firewave]

I did not blindly add the parameters as it would change the behavior. This needs to be evaluated for each case if this was intentional or not.

[chrchr-github]

I think we should always pass settings if available, since that should only improve the results.

[firewave]

I think we should always pass settings if available, since that should only improve the results.

Alright. Will do.

I was thinking about setting breakpoints to the lines where no options are being passed to be able to extract some test cases. But that can still be done.

[firewave]

It turns out this has quite a ripple effect so we should probably do that in a separate PR.

[firewave]

It turns out this has quite a ripple effect so we should probably do that in a separate PR.

See #6298.

[chrchr-github]

https://doc.qt.io/qt-6/qwidget.html#QWidget So there should be a noticeable difference in window behavior when passing a parent. Are those classes ever used as child windows?

[firewave]

I will re-structure these PRs.

[danmar]

So there should be a noticeable difference in window behavior when passing a parent. Are those classes ever used as child windows?

Spontanously I don't think so. We either always use the Qt classes with parent in a window. Or always as a window without parent. I vote to remove the default value.