cppcheck icon indicating copy to clipboard operation
cppcheck copied to clipboard

Published 20 hours ago • verified publisher icon danmar

added `triage.py` for running a code sample against a given amount of Cppcheck binaries

Open firewave opened this issue 3 years ago • 4 comments

I have been using this for quite a while now and made adjustments so it will also work with commit hashes so I think this is ready for a review now.

firewave avatar Aug 01 '22 08:08 firewave

There's still some polishing needed and I need to finish the version handling. Also some documentation is needed.

Integrating it better with the bisect script from #4286 also seems to make sense. As well as somehow integrating it with reduce.py or even daca comes to mind.

Also the name is totally wrong since it won't "diff" anything by default (and doesn't even diff anything yet). compare also seems wrong. Any suggestions are welcome.

firewave avatar Aug 01 '22 08:08 firewave

Maybe binbisect?

chrchr-github avatar Aug 01 '22 09:08 chrchr-github

Maybe binbisect?

It does not bisect anything. It just iterated over a list of executables.

That would be a sub-functionality like actual diff. Finding out between which versions it changed and invoking the appropriate bisect - essentially automating what I do manually now.

firewave avatar Aug 01 '22 09:08 firewave

I decided to name it triage.py which seems to make more sense given the future integration with things like bisect and reduce as well as daca.

I will also look into sharing some of the functionality with the triage GUI tool.

firewave avatar Aug 14 '22 12:08 firewave

There's also some other tools in the tools (like the times stuff) folder which could probably be merged into this.

firewave avatar Aug 15 '22 14:08 firewave

I think this is now fine for a first version to commit. So please review now.

I keep this as draft until it is approved since I currently removed all the GitHub actions to avoid unnecessary builds.

firewave avatar Aug 15 '22 14:08 firewave

@chrchr-github @danmar This appears to be quite stable now (I had not have to make adjustments for a week now) and I would like to get it merged - so an actual review would be appreciated. The documentation could probably be improved but I think it is mainly self-explanatory.

Also as mentioned before I will keep the GitHub Actions removed until the reviews are done to reduce the turnaround times and avoid unnecessary builds.

firewave avatar Aug 23 '22 15:08 firewave

I decided to name it triage.py which seems to make more sense given the future integration with things like bisect and reduce as well as daca.

It would be nice to rename this to triage_version.py. As it would be nice to have a triage.py script in the future to handle the daca@home debugging as the GUI is not easy to use especially over remote machines. It would be nice to have a script to download the source files, run cppcheck, and open relevant files using $EDITOR.

pfultz2 avatar Aug 23 '22 23:08 pfultz2

It would be nice to rename this to triage_version.py. As it would be nice to have a triage.py script in the future to handle the daca@home debugging as the GUI is not easy to use especially over remote machines. It would be nice to have a script to download the source files, run cppcheck, and open relevant files using $EDITOR.

As mentioned in my comments above that's what I am planning to in the future. Integrating all of those parts/functionality together - even the GUI.

firewave avatar Aug 23 '22 23:08 firewave

It would be nice to rename this to triage_version.py.

I am gonna rename this so we can get it pushed. After all it's just a name and we can still change it afterwards.

firewave avatar Sep 28 '22 16:09 firewave