cppcheck icon indicating copy to clipboard operation
cppcheck copied to clipboard

Tokenizer: run `simplifyTypedefCpp()` on C++ code only

Open firewave opened this issue 1 year ago • 4 comments

firewave avatar May 31 '24 10:05 firewave

@chrchr-github There are some failing tests. Could you please have a look?

firewave avatar May 31 '24 10:05 firewave

Could be that simplifyTypedefCpp() is a misnomer and actually needs to run for C code as well... @danmar

chrchr-github avatar May 31 '24 10:05 chrchr-github

It was introduced in c79d859f8bd1630b7b720a625bfd1c9cf88b6416.

firewave avatar May 31 '24 12:05 firewave

Could be that simplifyTypedefCpp() is a misnomer and actually needs to run for C code as well... @danmar

Looks very much like it. The function has isCpp() checks across the code.

firewave avatar Jun 03 '24 08:06 firewave

Closing as this is obviously the wrong thing to do. Will add a TODO about it in an upcoming PR which adds lots of other TODOs.

firewave avatar Sep 19 '24 10:09 firewave