cherrymui
cherrymui
> reinstalls it on every call (!) That means even if we set SA_ONSTACK for their handler, they will reinstall and overwrite it?
https://git.musl-libc.org/cgit/musl/tree/src/thread/synccall.c#n102 Does it mean that they remove the handler at exit of the call? Hm....
This stack looks weird. 0x12eb5 is not even an aligned PC (ARM64 instructions are always 4 bytes). Why would it appear on the stack? 0x3ff93 from another stack trace is...
Thanks for the details @lizthegrey ! > similarity to https://github.com/golang/go/issues/52829, does this need to not have NOFRAME ie https://go-review.googlesource.com/c/go/+/405482/? I don't think this is necessary. The ARM32 function contains a...
@lizthegrey @prattmic thanks for the information! The most recent one doesn't have morestack or systemstack, so it may be not limited to that. I'm still puzzled by the unaligned-PC-like values,...
Thanks! ``` previous frame 0 {pc:0x7cdc0, lr:0x24cb8, sp:0x406e1b24c0, fp:0x406e1b24c0} previous frame 1 {pc:0x24cb8, lr:0x241a4, sp:0x406e1b24c0, fp:0x406e1b24c0} previous frame 2 {pc:0x241a4, lr:0x241a4, sp:0x406e1b24c0, fp:0x406e1b2530} ``` This is weird. It shouldn't be...
> So 0x7cdc0 is probably in morestack If this is in morestack, I think that makes sense. `morestack` itself doesn't have a frame, so that's "frame 0" above. Its caller...
`morestack` writes SP, so it should have SPWRITE bit set. If the jump stack logic doesn't kick in, it should stop here https://cs.opensource.google/go/go/+/master:src/runtime/traceback.go;l=201 . Unfortunate for profiling, but doesn't crash....
``` diff --git a/src/runtime/asm_arm64.s b/src/runtime/asm_arm64.s index 7836ba1d96..ec29cd2038 100644 --- a/src/runtime/asm_arm64.s +++ b/src/runtime/asm_arm64.s @@ -321,6 +321,7 @@ TEXT runtime·morestack(SB),NOSPLIT|NOFRAME,$0-0 TEXT runtime·morestack_noctxt(SB),NOSPLIT|NOFRAME,$0-0 MOVW $0, R26 + MOVD RSP, RSP // force SPWITE...
@lizthegrey have you seen more failures and do you have any logs to share? Could you doublecheck that the binary includes the patch? Thanks!