cherrymui

Results 215 comments of cherrymui

Thanks @lizthegrey ! This is great. I'll send a CL soon. And thank you very much for providing the debug logs and helping us find the issue.

@gopherbot please backport this to previous releases. This may cause a runtime crash. Thanks.

I think you can just call `(*Loader).auxs` ( https://cs.opensource.google/go/go/+/master:src/cmd/link/internal/loader/loader.go;l=1854 ), and drop the `IsExternal` condition. Also, see https://go.dev/doc/contribute for how to contribute to Go. We cannot do code review on...

Technically it includes linux/arm64 as well. But generally one would not build programs with `-debugtramp=2` flag. In the default setting, trampolines may still be used if the program is very...

Maybe it could rewrite to something like ``` var m func() func init() { m = New[int]().M } ``` So it will not be a "package-scoped closure"?

Perhaps the reflect package can can just import reflectlite and build on top of it, instead of duplicating code. (The reflectlite package may need to export more things for reflect...

I was mostly thinking about reading the code. It would be nicer if the code stays together. For documentation, reflectlite doesn't define many types for reflect to export, so it...

I think we only support GOARM=5 on Linux. On other OSes we only support GOARM=6 or 7. I think it is okay to have a check with better error message...

Does the build complete? This print is not an error and does not terminate the build. (See #31544) Does your program not use cgo (import "C")? It is probably not...