cherrymui
cherrymui
@klauspost thanks for the feedback! > Non-main packages I totally agree that PGO for non-main packages are important (we want to do it for the standard library as well), and...
Thanks. I think we all agree that we want the compiler to emit an optimization list for optimizations it does based on a given profile. Interesting idea about profile invalidation....
@rajbarik yes, this is what we are proposing. https://go.googlesource.com/proposal/+/master/design/55022-pgo.md#stability-to-source-code-and-compiler-changes "We propose using function-relative line numbers ..." > It is unlikely that a PGO enabled binary will crash in production compared...
Sounds like there is a workaround. Is there anything still needed to be addressed in the runtime? Thanks.
https://github.com/golang/go/issues/55269#issue-1379533143 mentions commit cf53990 or 4c414c7 . It is unlikely the former, but the latter is possible, which changes scheduling. Is there a way we can do the build ourselves?...
The culprit CL has been reverted. I think we can close this.
> But I think it might be a better fix if the address fetching operation depends on the variable's definition operation, like op LocalAddr We thought about this before. But...
cc @dmitshur @jamalc
There is an issue about fork/exec on macOS #53863 , which looks like a kernel issue. I wonder if this has any connection with that.
cc @ianlancetaylor @thanm