cherrymui
cherrymui
> where the call expression is not a ONAME node Sorry, I must still have missed something. When would a call expression be an ONAME node? I'd think a call...
> (*Object).Initialize(obj) is the callee expression of the call expression (*Object).Initialize(obj).Update() Sorry, I must still have missed something... If by "callee expression" you mean the function being called, in this...
Sorry for the late reply. I agree with @dr2chase that targeting the escape analysis is the right thing to do here. And the heuristic of using the minimum level where...
Besides the escape analysis change, I think the escape analysis diagnostics also needs some improvement. If it is the assignment `.autotmp_3 = ~R0` causing the escape due to loop depth,...
> goroutine 23250 [runnable]: runtime.goexit1() /workdir/go/src/runtime/proc.go:3616 +0x54 fp=0xc000750fe0 sp=0xc000750fd8 pc=0x448934 runtime.goexit() /workdir/go/src/runtime/asm_amd64.s:1599 +0x6 fp=0xc000750fe8 sp=0xc000750fe0 pc=0x47a766 created by runtime_test.TestDebugCallUnsafePoint This looks like the `debugCallUnsafePointWorker` goroutine is just exiting. It is...
#32023 may be related. Are they same?
Agreed. Done.
Thanks for the contribution! It is nice that it only causes a small binary size increase. Yeah, I'll review during the 1.21 cycle (probably not _very_ soon, though). Thanks.
Hi @qmuntal , what is the status for this now? Is there more to do? Should we bump to Go 1.23? Thanks.
@qmuntal Also, is there anything that worth mentioning in the Go 1.22 release notes? Thanks.