cherrymui comments

Results 215 comments of


                                            cherrymui

all: stop using direct syscalls on OpenBSD

Thanks @odeke-em. Moved to 1.17. There are still 386, ARM (32-bit), MIPS64.

all: stop using direct syscalls on OpenBSD

Reviewing the 386 CL is still on my list. It is not forgotten. I'll do it as soon as I can. The register ABI stuff has been keeping me occupied,...

all: stop using direct syscalls on OpenBSD

This is probably due to #31544. If the programs can be built correctly and the only issue is the warning prints, that is probably fine. We have that in the...

x/website: define the term `root module` in ref/mod

cc @matloob @bcmills

build: run.bash: make test configuration independent of the user's GOENV file

cc @bcmills

runtime: corruption in tests

This is #54596 . I updated pattern there. For this issue, does watchflakes suppose to reopen it as it found a new failure? @rsc

reflect: TypeOf interface with methods using generic types includes package path in type

Yeah, I think that the current state is not bad. The question is why this is a problem for gomock. It looks like it is used for generating code? It...

runtime/pprof: TestLabelSystemstack failures

Close as a dup.

proposal: profile-guided optimization

@rhysh thanks for the feedback! Yes, if we later switch to a different format, we will provide a tool to convert profiles between the formats. And yes, if we choose...

proposal: profile-guided optimization

Interesting idea about compiler optimization directive list for bug report. Thanks. I thought for bug report due to PGO we would expect one to share the profile in order to...