cherrymui comments

Results 215 comments of


                                            cherrymui

cmd/nm: running nm on object from different version can crash

Yeah, we should update the magic number. And it is a good idea to have mkbuiltin.go automatically updates it.

runtime: crash on linux/arm64 during os.Setenv

What is your host machine? Are you running docker as a VM? It looks like this is crashing in the C setenv function. What are your libc and C toolchain?...

runtime:cpu2: TestCoroCgoCallback failures

Dup of #74187

cmd/compile: update compiler's PGO profile

> Ideally we can shrink the profile a little When I did it I put GOROOT in /tmp so the file paths are short. We could probably also trim cold...

cmd/compile: update compiler's PGO profile

Currently I'm not expecting another update, but I can doublecheck before the RC, in case there are some more changes in the compiler.

net/http, x/net/http2: data race in multiple tests

Closing with the assumption that it is fixed. Thanks.

cmd/compile: suboptimal zeroing of multiple registers on amd64

Have you measured the performance? Or is it just about the binary size? Thanks.

cmd/compile: suboptimal zeroing of multiple registers on amd64

Using the same issue is fine.

cmd/compile: avoid always escaping the receivers in interface method calls

With `GODEBUG=invalidptr=2`, I think we can enable it by default (assuming the run-time overhead is negligible). That gives users a chance to temporarily turn it back to `invalidptr=1` to unblock...

cmd/compile: avoid always escaping the receivers in interface method calls

Hi @thepudds ! Thanks for the update, and for returning to this! I'd be happy to continue the review on the CLs (runtime, reflect, and the compiler), as well as...