Brent Shaffer

Results 407 comments of Brent Shaffer

On the Java page, there's documentation regarding the protobuf options `java_package` and `java_outer_classname`: https://protobuf.dev/getting-started/javatutorial/ But PHP has no such documentation for `php_namespace` and `php_metadata_namespace`

@skuruppu follow the steps in our [spanner emulator workflow](https://github.com/googleapis/google-cloud-php/blob/main/.github/workflows/spanner-emulator-system-tests.yaml) to run the emulator tests. Note that they require `docker`.

I created a release for this here: https://github.com/bshaffer/oauth2-server-php/releases/tag/v1.14.2 Thanks for your contributions!

Hi @gjvanahee ! This looks great, thank you for contributing this. Coincidentally, I was just working on this in https://github.com/googleapis/google-auth-library-php/pull/580! We will get this merged soon, and then merge your...

@gjvanahee If you'd like to help, you could use test https://github.com/googleapis/google-auth-library-php/pull/580 in your own use-case. I would love to have you review it! ``` composer require google/auth:dev-add-impersonated-service-account-credentials ``` I'll use...

Closing this PR as it should be completely implemented by https://github.com/googleapis/google-auth-library-php/pull/580

@margar-melkonyan please sign the cla!

Hi @SySafarila ! Thanks for your contribution, this looks great! Before we can merge it, you will need to sign our Contributor License Agreement (CLA). All contributors must be covered...

@anandolee When you say "drop", do you mean "release"? And if so can we really try to get this merged before then?

Expanding on this to say that because the [googleapi public protos](https://github.com/googleapis/googleapis/blob/c98457cd51f80e56daf7de102ed8d4c347ada663/WORKSPACE#L152) are on protobuf 25, all the client libraries generate messages using that protobuf version. We are trying to update...