Brent Shaffer

@dwsupplee @jdpedrie this is ready for review!

@wlasnapl we do not have an ETA on that, but we do support `psr/cache:v2`, and _any repository_ which supports `psr/cache:v3` _SHOULD_ support `psr/cache:v2` as well, for compatibility. That will prevent...

See https://github.com/googleapis/google-auth-library-php/pull/359

@antongrbin I can take a look

We do! On Mon, Feb 13, 2023, 7:55 PM Joshua Haberman ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In src/google/protobuf/compiler/php/php_generator.cc > > : >...

This is kinda bizarre - so if you ignore a PR for long enough you use that as justification to close it?

@haberman so a few thoughts on this... There are a few issues with typing things as we have now. This depends on the context of. the typehint: ## Typehinting a...

> What about `ArrayAccess`? That seems like the most accurate type to return. `ArrayAccess` is similar to marking as `Traversable` in the sense that it's a more narrowly scoped type....

Another thought on this is we could typehint the returns as `ArrayAccess&Traversable` using the [Intersection Types](https://php.watch/versions/8.1/intersection-types) in PHP 8.1. This mirrors the actual [`RepeatedField`](https://github.com/protocolbuffers/protobuf/blob/main/php/src/Google/Protobuf/Internal/RepeatedField.php) implementation, which implements `ArrayAccess`, `IteratorAggregate` (which...

Heads up @haberman , we are receiving a few issues (https://github.com/protocolbuffers/protobuf/issues/14666, https://github.com/protocolbuffers/protobuf/pull/15673) related to this. I think we should make a decision on how to support them!