oauth2-server-php icon indicating copy to clipboard operation
oauth2-server-php copied to clipboard
verified publisher icon bshaffer

Add explicit null to nullable types for PHP 8.4

Open sapphirecat opened this issue 11 months ago • 2 comments

Minimal fix for #1073. Adds the explicit ? to implicitly nullable arguments within the src tree.

sapphirecat avatar Jan 31 '25 16:01 sapphirecat

Incidentally, on my system (no postgres/cassandra/mongo), php 8.3 and 8.4 produce the same results from phpunit:

OK, but incomplete, skipped, or risky tests!
Tests: 438, Assertions: 1092, Skipped: 160, Risky: 16.

Is anything else needed from me to get this merged?

sapphirecat avatar Feb 10 '25 18:02 sapphirecat

Works as advertised as far as I can tell.

@bshaffer would you be able to cut a new release of the library once this is merged?

cafuego avatar Mar 04 '25 03:03 cafuego

Looks good, would be nice to have this merged up.

paul-rankin avatar Mar 28 '25 11:03 paul-rankin

🙌🏻

cafuego avatar Mar 28 '25 21:03 cafuego

I created a release for this here: https://github.com/bshaffer/oauth2-server-php/releases/tag/v1.14.2

Thanks for your contributions!

bshaffer avatar Mar 28 '25 21:03 bshaffer