Brent Shaffer comments

Results 407 comments of


                                            Brent Shaffer

Can't read docs with multiple tabs

Can you confirm that the document retrieved by `$doc_service->documents->get($documentId)` looks as expected other for the lack of tabs? If so, then there may be an API bug. The next step...

Dependency Dashboard

TODO: Remove this

PHP 8.4 deprecations due to missing nullable types

Thanks for bringing this up! This should be an easy fix

chore(workflow): make major version releases safer

I've added https://github.com/googleapis/google-cloud-php/pull/8779 to test that the check works as expected

chore(workflow): make major version releases safer

Removing the "next release" label because I'm seeing some strange behavior in https://github.com/googleapis/google-cloud-php/pull/8779 - a new review creates a duplicate actions check instead of replacing the first one. Also we'll...

Not able to use the PubSub Emulator

This looks like it'll be fixed with https://github.com/googleapis/gax-php/pull/582 (or something similar). See https://github.com/googleapis/google-cloud-php/issues/7187 for more info.

[PHP] mergeFromString() allows negative length varints, infinite loop / worker exhaustion DoS

@shaod2 this is absolutely something we should fix and it should be a high priority

[php][ext] Supports PIE

Thanks @asgrim , that's a nonstarter for this PR then. We will take a look at some other options.

Problem with createDataset

Hmm, I cannot reproduce this - the code provided runs as expected on my machine. I notice that you're on Windows, so perhaps that could have something to do with...

PHP: The phpdoc for enum getters/setters does not point to corresponding enum class

@piotrgradzinski to potentially work on this