Brent Shaffer

Results 407 comments of Brent Shaffer

@jontro can you describe a little bit more what you're asking for? This repo is for protobuf, you may be looking for the [gRPC repo](https://github.com/grpc/grpc), where those classes are defined,...

I see two potential solutions here: 1. Since this call is used internally, we could just remove the `trigger_error` warning, and say that the `@deprecated` tag in phpdoc will suffice...

@pkruithof I've made my own PR for this, because there were some tricky implementation details. See https://github.com/protocolbuffers/protobuf/pull/17788

Hello! Thank you for commenting on this. Does it work when you install the `grpc` extension for PHP? If so, I suggest doing this. In the meantime, if the emulator...

> (BTW: in our case we can not use grpc extension in PHP because it conflict with swoole / openswoole extension) Can you elaborate more on this? This is news...

@mrVrAlex > it is major breaking changes? No, because the emulators have _never_ worked with REST, only with gRPC. To confirm this, I checked out `v0.233.0` (which is the same...

The "Prefer Lowest" tests are failing because you've added a new `Trait` to `google/cloud-core`, you need to upgrade the minimum version of cloud core specified in `Spanner/composer.json`

I'll give this a more thorough review later today, but don't forget we need to remove all V1 GAPIC client classes. For Datastore V1, that would be `Datastore/src/V1/DatastoreClient.php` and `Datastore/src/V1/DatastoreGrpcClient.php`....