Brent Shaffer comments

Results 413 comments of


                                            Brent Shaffer

PHP: The phpdoc for enum getters/setters does not point to corresponding enum class

unassigning this because I do not have this prioritized yet, but it's on our backlog as ready to work on

throws Maximum Call Stack Size errors when using GRPC (PHP pecl) library 1.69.0.

@lcobucci thanks for reaching out! I am not on the gRPC team, and they have been strangely silent on the issue, so I am as frustrated as you. I will...

throws Maximum Call Stack Size errors when using GRPC (PHP pecl) library 1.69.0.

See https://github.com/googleapis/gax-php/pull/632 for an example of how this issue is causing our customers friction and frustration

throws Maximum Call Stack Size errors when using GRPC (PHP pecl) library 1.69.0.

@pawbhard I think this analysis might be off... this doesn't make sense for a few reasons: 1. Rolling back gRPC fixes the issue 2. We make many calls using our...

undelcared identifier "phpext_grpc_ptr" on windows server docker image

We are seeing PHP 8.4 installation of grpc failing in our Windows CI. If this is an issue that makes grpc incompatible with PHP 8.4 on windows, it should be...

undelcared identifier "phpext_grpc_ptr" on windows server docker image

please take a look at this one as well, @pawbhard

Add interfaces to be possible the mock of the client, batch and service

Hi @pedrocarmokununu ! Why do you need interfaces in order to mock these classes? They are not final, so you can mock them directly.

PHP Extension - Inconsistent final modifier for Google\Protobuf\Timestamp

@PilgrimMemoirs removing `final` from the `Timestamp` class in the extension is not a breaking change

fix: Throw exception on invalid base64

It looks like it currently throws an `InvalidArgumentException` but you want it to throw a `UnexpectedValueException`? As this would be a breaking change, wouldn't it be better to just reflect...

PHP - Inconsistent mergeFromJsonString behavior

As changing the behavior of the native implementation would be breaking, to make this consistent we would need to accept `[]` as valid in the C-extension.