google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

chore(spanner): enable PG tests to run on emulator

Open skuruppu opened this issue 1 year ago • 4 comments

skuruppu avatar Aug 02 '24 00:08 skuruppu

This looks good, but the emulator tests are failing so I suppose something is still wrong. is it because the emulator version needs to be updated?

Thanks for the quick reply @bshaffer. Unfortunately, I haven't been able to get the tests to pass so this PR needs work. I don't think it's a version issue. I think there are either gaps in the PG support in the emulator or the calls are being made in a way that's not supported by the emulator.

I haven't been able to get the tests to run locally to figure out what's going on. I'll keep trying and get back to you.

skuruppu avatar Aug 05 '24 01:08 skuruppu

@skuruppu follow the steps in our spanner emulator workflow to run the emulator tests. Note that they require docker.

bshaffer avatar Aug 05 '24 16:08 bshaffer

@bshaffer sorry for the delay. I finally got back to this resolved the issues. The tests now pass against the emulator but ones with known failures are skipped (with explanations).

PTAL

skuruppu avatar Sep 13 '24 01:09 skuruppu

Friendly ping @bshaffer on the review.

skuruppu avatar Sep 24 '24 00:09 skuruppu