freebsd-src bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

Testing cross-OS bootstrapping

Aug 07 '23 02:08 jrtc27

We currently have LD_FATAL_WARNINGS=no in:

lib/libbsnmp/libbsnmp/Makefile
usr.sbin/nmtree/Makefile

The second is curious, if nothing handled it in bsd.prog.mk anyway. It was added in c4bd82d701879

Aug 10 '23 14:08 emaste

Yeah, that was upstreamed from CheriBSD without noticing that it didn’t do anything in FreeBSD

Aug 10 '23 15:08 jrtc27

Looks good to me as well

Aug 10 '23 15:08 bsdimp

Just need to revisit and figure out why amd64-gcc12 is sad with this

Aug 10 '23 15:08 jrtc27

Oh it's pretty simple, LLD still doesn't bother to implement this feature... https://github.com/llvm/llvm-project/issues/41353 sigh

Aug 10 '23 22:08 jrtc27

What are the warnings we get with amd64-gcc12?

Aug 10 '23 23:08 emaste

Cirrus CI amd64-gcc12 died with:

/usr/local/bin/x86_64-unknown-freebsd13.1-ld: dlopen_empty_test.o: in function `atfu_dlopen_empty_test_body': /tmp/cirrus-ci-build/lib/libc/tests/gen/dlopen_empty_test.c:66: warning: warning: mktemp() possibly used unsafely; consider using mkstemp()

I'm doing a build locally with amd64-gcc12 to see if there are any others past that.

Aug 10 '23 23:08 jrtc27

So what's the status here? Seems like this should just be closed since it was a testing PR, but maybe I'm missing something

Dec 27 '23 23:12 bsdimp

I need to get back to the patch in the new year; a bunch of tests have warnings due to uses of deprecated functions; some intentional that need suppressing, others just old crusty code that is better to rewrite.

Dec 28 '23 00:12 jrtc27

That is I eventually intend to update the branch and thus testing PR

Dec 28 '23 00:12 jrtc27

Ok marking in progress until then...

Dec 28 '23 01:12 bsdimp

@jrtc27 any status update?

Jan 26 '24 17:01 bsdimp

@jrtc27 any status update?

Not yet, but I'm starting to drain my backlog of TODOs, as you may have seen from my recent revivals of old patch series.

Jan 26 '24 21:01 jrtc27

@jrtc27 any status update?

Not yet, but I'm starting to drain my backlog of TODOs, as you may have seen from my recent revivals of old patch series.

Can we close this pull request?

Apr 17 '24 03:04 bsdimp

I'm cleaning up the pull requests... I'm going to close it. You can resubmit or reopen when you have time.

Apr 17 '24 15:04 bsdimp