Brian Burkhalter
Brian Burkhalter
On Linux, the `copy_file_range(2)` system call already includes file cloning if available, so there is no need to add an explicit call to `ioctl(2)` with request code `FICLONE` or `FICLONERANGE`...
I agree about having OS-specific `CopyFile` classes instead of OS-specific providers. I don’t like the `IOStatus` being in the provider and the call of `provider.clone()` seems odd. - `LinuxNativeDispatcher.ioctl_ficlone` uses...
> I skimmed the latest patch and I think the main thing that still needs to be worked out is how to integtrate "clonefile". Right now the current prototype adds...
> [...] I think gives you an example of how to add the clone method without needing fileCopier. Would you be able to try that? I suspect the patch will...
`clone()` moved to `{Bsd,Linux,Unix}FileSystem`; `{Bsd,Linux}CopyFile` removed.
> The main issue is that the macOS clonefile is forcing the patch to clone with file paths and this breaks the architecture where the source and target files are...
> What would you think about separating this two? That would be fine with me, but I think the BSD / Linux separation should be done under a different issue...
> > That would be fine with me, but I think the BSD / Linux separation should be done under a different issue with the `clonefile` work remaining under this...
Passed on 20 arbitrary nodes and on one where it failed previously due to user disk quotas.