Brian Burkhalter
Brian Burkhalter
If consensus is reached on this PR, I will proceed to the CSR and then the RN.
The throughput of the implementation as measured by the included benchmark appears to hover around 13% greater than that of the existing method. The updated method should also have a...
> If we want better performance, we should go a step further and overload the readAllLines method in the Reader implementation class. Perhaps, but not in this request. A separate...
The commit [d5abfa4](https://github.com/openjdk/jdk/pull/25863/commits/d5abfa450cb3fcd604560833038735e41952bce9) does not address most comments provided to date. The algorithm was wrong and I preferred to correct it first.
> The throughput of the implementation [...]. The performance comments made [here](https://github.com/openjdk/jdk/pull/25863#issuecomment-2982169343) still apply to the most recent commit.
> The modified code below is a PoC for reference. It seems to work as expected, though not fully tested. This looks like a nice reworking, and appears to pass...
> the throughput appears to back to normal with 'find term while loop' fast path This version passes the regression test and is a little faster than the latest PR...
Thanks @RogerRiggs, @xuemingshen-oracle for the approvals. I will hold off integrating until next week.
This passed 20 repeats on all CI platforms against an internal build created within the last 24 hours.