Brian Burkhalter
Brian Burkhalter
> Exactly, so I think the first step here has to validate that where we ended up in WindowsPath.compareTo is correct. `WindowsPath.compareTo` returns zero (equal) if and only if the...
> [I]t's not clear to me whether, using the strings alone, anything substantively different could be done. It's still unclear to me what else could be done for this issue,...
If this none too recent [MSFT blog entry](https://learn.microsoft.com/en-us/archive/blogs/greggm/comparing-file-names-in-native-code) is to be believed, `Path.equals` and the proposed changed version of `File.equals` match the behavior of the Windows operating system.
> [...] changing File means working through the compatibility impact [...] It's probably not enough, but: - `java.io.WinNTFileSystem.compare(File,File)` is invoked only by `File.equals`. - Tier 1-3 tests passed in the...
> [...] system property to restore long standing behavior. Added in a63e13e. /csr
> Would it be safer to make the new behavior as opt-in, as well as making the system property to be windows specific `windowsCompatibleEquals` or something? Making it as the...
@naotoj Thanks for the comments. > Would it be safer to make the new behavior as opt-in, Commit 53caf9e changes it to opt-in. > as well as making the system...
> LGTM. Thanks. > Probably someone else might want to review this too Yeah, good idea.