Brian Burkhalter
Brian Burkhalter
Yes, I was wondering about changing the organization of the native code files. It's not great to have them all in `/native/libjava`.
Perhaps `/native/libjava/nio/ch` and `/native/libjava/nio/fs`?
> Also think to work through some naming on IOUtil vs. NIOUtil as it won't be obvious to maintainers which class to use. Maybe `NIOUtil` should be `NetUtil` as its...
As part of 7e8a02e, the `nio_util.h` header files were modified. One unused symbolic constant was removed. Symbolic constants used in only one file were moved to that file. Function declarations...
> > Also think to work through some naming on IOUtil vs. NIOUtil as it won't be obvious to maintainers which class to use. > > Maybe `NIOUtil` should be...
> please do not integrate this change until I get time Sure, of course I will not. Thanks to @magicus and @dfuch for helping to make it better.
> Thanks for making the changes. LGTM, assuming that tests still pass. The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In any case, I will...
> Can you hold off integrating, I plan to go over the changes soon. I don't plan to integrate until you have reviewed it. I set the minimum reviewer count...