Brian Burkhalter
Brian Burkhalter
> The spec will need to explain/define how to trim off the extension, so the new extension can be added. Something like this perhaps for the nominal case? ``` Path...
> Keeping the `withoutExtension` method provides a place for that as a building block for `withExtension`. Might be a good reason to keep it.
> Probably need to add test cases for this. Testing definitely needs to be broadened, but I think it should wait until there is consensus on the proposed API(s). >...
> String s = name.substring(0, indexOfExt); I assume that `indexOfExt` is a typo which should be simply `index`.
> My two cents: Thanks for the comments. > * for `foo.`, wouldn't `removeExtension().addExtension(getExtension())` result in `foo`, i.e. the invariant be broken? It looks like it would be. Another problematic...
@txominpelu You need to remove the integration blocker by changing the title of this PR to match the summary of the issue ``` 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more...
@txominpelu I think you will need to reissue the `/integrate` command.
/sponsor
> WindowsPath.compareTo is where we ended up for JDK 7, it would be good to validate this. I assume that you intend here validating correctness with respect to the NTFS...
> > Just wondering how Windows implementation really behaves for its 'case-insensitive-comparing" for "\u0131 vs "I". I would assume they actually are 2 'distinguished" files? > > I think it...