Brian Burkhalter comments

Results 102 comments of


                                            Brian Burkhalter

8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory

ee76ec1 changes the test to fail if the amount of memory able to be allocated is less than a threshold, in this case,`MAX_VM_SIZE - 8*1024`. This change passed 30 repeats...

8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory

/label add nio

8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory

This request will likely be withdrawn when #22339 is integrated.

8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory

This request is irrelevant now that #22339 is integrated.

8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning

The `InternalLock` and `ByteArrayOutputStream` changes look all right. I'll follow up with [JDK-8343039](https://bugs.openjdk.org/browse/JDK-8343039) once this PR for [JEP 491](https://openjdk.org/jeps/491) is integrated.

8348828: Windows dll loading now resolves symlinks

> > New-Item -Path .\jdk-24\bin\jimage.dll -ItemType SymbolicLink -Value .\rando What if instead this were the following ``` > New-Item -Path .\jdk-24\bin\jimage.dll -ItemType SymbolicLink -Value .\rando.dll ``` where `.dll` is appended...

8348828: Windows dll loading now resolves symlinks

> > > At this point, the path to load will be `$PWD\rando` due to symlink resolution. > > > > > > Which is in fact correct, no? >...

8348828: Windows dll loading now resolves symlinks

> > So is it correct to say that the link resolution appears correct but `LoadLibrary`'s quirks cause the intended behavior to fail? > > Yes. The `getCanonicalPath` canonicalization indeed...

8348828: Windows dll loading now resolves symlinks

I built the JDK with the diff in 70e943c applied on Windows 11 and verified that it resolves the scenario presented in the issue description, namely that `jimage.dll` can be...

8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

This change passes CI tiers 1-5 jobs on all platforms. With the change in place, one can remove `libnio` from the JDK and still be able to copy a file...