Benjamin Pasero

Results 228 comments of Benjamin Pasero

Feel free to ping me on the extension issue, I would like to reproduce myself.

Does not look so good: I suggest to see if script streaming enabled on Windows helps.

Thanks, just from the numbers it does look like for you `1.71.0` overall executes slower. To drill in we would probably have to check the numbers from the performance editor...

Fyi summary of my experiments: * cannot reproduce a slowdown on my new Surface Laptop 3 with Windows 11 [1] * running exploration build on the perf bot * same...

I wonder if this could possibly be a result of opening VSCode in the background as a service, vs. opening it normally. We do pass the flags to disable Window...

> On a high note: mac (at least) is significantly faster now. Almost by 1 second, I guess that's because of the improved crash reporter 👍 , this is a...

Looking at the `T_windowload` regression: ![image](https://user-images.githubusercontent.com/900690/186633877-49bb5217-4d7d-490d-9d8f-c3da0d329107.png) I feel like the most recent perf regression is from Aug 16th to 17th which puts us here: https://github.com/microsoft/vscode/compare/8e42bda5487a953d59fab7792eedd4ca209cabba...dd0ed9381aa5d0d43159463ccad1f7e060021580 Where https://github.com/microsoft/vscode/commit/2857051bb4e1bd7177c0d48b468b665c5a53b3c1 stands up to...

https://github.com/microsoft/vscode/pull/160957 bundles our main files into single files, avoiding multiple `require` calls that have to go to disk. It covers `main.js`, `cli.js` (and also our server startup files). Before we...

https://github.com/microsoft/vscode/pull/161095 does the same for the files we require via non-async `` tags in `workbench.html`. This requires us to ship 2 versions of the HTML files, depending on running out...