Benjamin Pasero

@ashtuchkin if it helps, feel free to copy anything from our `VSBuffer` helper that is meant as a drop-in replacement for `Buffer` to work in node.js and browser environments. The...

Maybe as an alternative, `string | Buffer` could be supported, similar to how node.js streams support both.

Yes, would also be interested in this. I think this would enable VS Code to implement a dialog like this one:  Refs: https://github.com/Microsoft/vscode/issues/44505

@paulmillr > I've looked into various projects including vscode - doesn't seem like many people are using followSymlinks: false So these test failures only impact if you configure `followSymlinks: false`?...

> Yes, i've made a call to release 3.4 with the broken test because vscode and other projects aren't using the functionality. So, all good. 👍 > The link handling...

Yeah I brought this up because we got some reports from users asking for this feature and we use jschardet when users have enabled auto-guessing of encoding. Maybe this could...

@aadsm here is the output: ``` EUC-TW prober hit error at byte 207 UTF-8 confidence = 0.505 SHIFT_JIS confidence = 0.01 EUC-JP confidence = 0.99 GB2312 confidence = 0 EUC-KR...

I was reporting this on behalf of VS Code.

@hediet oh, the monaco diff editor has a much improved compare view miles ahead of what GH provides. Take this example how it renders on GH:  vs VSCode where...

Yeah no worries :)