Benjamin Pasero
Benjamin Pasero
Interesting, on Linux: ``` [playwright-install] $ node build/azure-pipelines/common/installPlaywright.js [playwright-install] 2022-09-19T20:17:10.061Z pw:install downloading Chromium 104.0.5112.48 (playwright build v1015) - attempt #1 [playwright-install] 2022-09-19T20:17:10.062Z pw:install running download: [playwright-install] 2022-09-19T20:17:10.063Z pw:install -- from...
Note that we are on `1.24.2` currently. Is it worthwhile updating?
I will see to update to `1.25.2`.
I also feel that the update has helped us, so maybe that was the fix needed? However, that does still not explain how it suddenly started, because we had been...
Thanks, will review when I find time for it. @lramos15 fyi for explorer changes.
Sorry, will probably not have a lot of time this month, might push this back a bit.
@gjsjohnmurray I am not easy accepting this change, especially forcing `requireMetadata` will have a severe significant impact on explorer performance and this case here only impacts a handful of users....
Ah so, this originates from your change @misolori https://github.com/microsoft/vscode/commit/ef84173ea6e64ee8f7126bbf3f5dc2c51eff798b#diff-b4dccdf238cc73547c4eefcfbac679210115fd5e0dc2fc9902844d6116b0e915 Maybe you have an idea. It used to be `display: inline-block;`
Before boiling the ocean, an alternative is to wrap whitespaces into `span` itself to preserve them. I.e. here: https://github.com/microsoft/vscode/blob/fcbf1eb903ad019fbd003d754067d0728d79d498/src/vs/workbench/browser/parts/statusbar/statusbarItem.ts#L285 and here https://github.com/microsoft/vscode/blob/fcbf1eb903ad019fbd003d754067d0728d79d498/src/vs/workbench/browser/parts/statusbar/statusbarItem.ts#L290 Something along the lines of: ```ts renderLabelWithIcons(text ??...
I think you are confusing things. There is a `display: flex` for status bar items on the parent container of the items to position them and yes maybe we can...