Benjamin Pasero
Benjamin Pasero
I do not have a good answer to the fact that VSCode decides to ignore changes in `node_modules`. We do that to protect against flood of file events, but it...
@devongovett unfortunately the JavaScript approach wouldn't be a good solution for VS Code at least: for Linux it is important to apply the ignore rules at the level of where...
What a fantastic idea to convert from JS to RegEx, I was not even thinking about that. We can then just use our existing code to convert from VSCode 💯
I believe on Windows you are always dealing with a case preserving but case insensitive file system so a pragmatic approach would be to ignore casing when comparing paths. We...
I think the problem is here: https://github.com/parcel-bundler/watcher/blob/728b44aeec7801bae9b11e02a7fb3f0bdf94b924/src/windows/WindowsBackend.cc#L199 There is a `\` added to the path, but the path will actually have a trailing backslash if just the drive letter is...
@devongovett fyi if you had thoughts on this
@devongovett we have an ask in https://github.com/microsoft/vscode/issues/3025 to allow VSCode extensions to use our official API for monitoring folders for file changes. Out of the box we only watch the...
Yeah, I think the debouncing is clever, especially since it allows to normalize duplicate events or coalesce them. We do that as well, but emit the event at least once...
A similar issue exists when you pipe the output of `ping` to a file: * Windows: `ping -t 127.0.0.1 > out.txt` * Posix: `ping 127.0.0.1 > out.txt` Parcel watcher does...
@devongovett just to clarify, there is a 50ms debounce delay across all platforms to collect events before emitting. right? I was curious about the debounce delay that is used and...