Benjamin Pasero

Results 228 comments of Benjamin Pasero

I would say we never had this issue before it only started relatively recently. Can playwright print more info from the install command? ``` yarn run v1.22.19 $ /Users/runner/work/1/s/node_modules/.bin/npm-run-all -lp...

via https://github.com/microsoft/vscode/pull/161099

@mxschmitt we had 2 cases now after I added logging. **Case 1** Error: `browserType.launch: Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/webkit-1683/pw_run.sh` (from [build](https://dev.azure.com/monacotools/Monaco/_build/results?buildId=185614&view=logs&j=9833cdaa-2e92-5f8d-56a8-239fd18fd628&t=9fd0bccc-90ad-5118-165a-bb6fa0e94027&l=21)) Logs: ``` ============================================================================== Generating script. ========================== Starting Command Output...

Another one: ``` 2022-09-19T05:54:27.6511180Z ##[section]Starting: Download Electron and Playwright 2022-09-19T05:54:27.6522850Z ============================================================================== 2022-09-19T05:54:27.6523520Z Task : Command line 2022-09-19T05:54:27.6524070Z Description : Run a command line script using Bash on Linux and macOS...

Is there a command to verify the success of playwright install that we could maybe run to retry this?

Btw our install script calls `const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server');` directly, is there a better way or is this discouraged? We also `retry` this call up to 10 times.

One idea is that it was maybe caused by using `retryCountOnTaskFailure` in Azure CI, we will revert this change and see how it goes.

We need to consume playwright via `npm`, but maybe we could just get the sources to download playwright and inline them into our install script?

I am not sure we can patch the node.js executable that is used by Azure CI to be honest.

So it seems the log is indicating the issue, e.g. here: ``` 2022-09-20T08:20:48.5754130Z [playwright-install] 2022-09-20T08:20:48.568Z pw:install -- to location: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright-download-firefox-mac11-1335.zip 2022-09-20T08:20:48.7606970Z [playwright-install] 2022-09-20T08:20:48.752Z pw:install -- response status code: 200 2022-09-20T08:20:48.7708180Z...