Benjamin Pasero

icon indicating a website link http://code.visualstudio.com icon indicating an email [email protected]

icon company Microsoft icon location Zurich, Switzerland icon location I am a software engineer at Microsoft in Zurich, Switzerland since 2011. Our team started VS Code when it was still called Monaco.

Results 228 comments of Benjamin Pasero

Select box near top of screen opens upwards, leaving little space for the items (and a scrollbar)

@nornagon it reproduces in Electron's Fiddle app itself: ![image](https://user-images.githubusercontent.com/900690/111264946-adf10600-8628-11eb-93c4-8bbbf0426801.png) Just place the window above the dock and right click.

Select box near top of screen opens upwards, leaving little space for the items (and a scrollbar)

This still reproduces for me in VSCode using Electron 11.4.1 ![image](https://user-images.githubusercontent.com/900690/113571832-5f2b0080-9617-11eb-9639-2ff33ae19eb9.png) //cc @deepak1556

Select box near top of screen opens upwards, leaving little space for the items (and a scrollbar)

No, just a single external monitor with 2K resolution (2560x1440).

Select box near top of screen opens upwards, leaving little space for the items (and a scrollbar)

How can we move this forward? Interestingly I see related issue https://github.com/electron/electron/issues/5451 was fixed with https://github.com/electron/electron/pull/5518 //cc @deepak1556 @zcbenz

ability to validate UTF-8 encoding

@ashtuchkin I was thinking of a similar request today. Is there any way to know (after a call to encode) that the output is bogus? I think iconv is more...

ability to validate UTF-8 encoding

@ashtuchkin got it. But in the docs you say "Untranslatable characters are set to � or ?", so it might also be "?" which I cannot really check for because...

ability to validate UTF-8 encoding

Right, but "?" is ambiguos because it might also be a character used in the original text. I think raising some flag or error would make more sense to catch...

ability to validate UTF-8 encoding

In our case, we use encode() to convert an existing file to another encoding. E.g. we have a source UTF-16 file that we want to save as DOS encoding. DOS...

ability to validate UTF-8 encoding

Makes sense!

Support using Uint8Array as the "bytes" data type (instead of Buffer)

This would be a requirement for VSCode to ship `iconv-lite` as part of the web experience 👍